Internalize ProductHeaderValue #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What Haacked, PaulBetts, and Shiftkey suggested
| { | ||
| ProductHeaderValue() | ||
| { | ||
|
|
There was a problem hiding this comment.
Please remove the newline.
And usings 👍
|
Think I got it all, apologies. I will update my resharper to match your style. |
|
Also, it looks like you created this off an old master branch. Please fetch and merge origin/master into your branch. Or rebase your branch off origin/master. Either way. |
|
I think I got it right (let me know if I didnt), through powershell and the Github for Windows app. Gave me a much deeper understanding of git. 👍 |
|
Great stuff! I'm going to run our build server against it and then I'll merge it once it passes. |
haacked
added a commit
that referenced
this pull request
Feb 28, 2014
Internalize ProductHeaderValue
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Haacked, PaulBetts, and Shiftkey suggested. Abstracted ProductHeaderValue, changed tests to use internal ProductHeaderValue.
Also, removed some unused usings in the tests if I saw them.